sanpwc commented on a change in pull request #321:
URL: https://github.com/apache/ignite-3/pull/321#discussion_r704222303
##########
File path:
modules/raft/src/main/java/org/apache/ignite/raft/jraft/rpc/impl/RaftGroupServiceImpl.java
##########
@@ -446,11 +523,37 @@ private boolean recoverable(Throwable t) {
* @return Random node.
*/
private Peer randomNode() {
- List<Peer> peers0 = peers;
+ List<PeerId> peers0 = peers;
if (peers0 == null || peers0.isEmpty())
return null;
- return peers0.get(current().nextInt(peers0.size()));
+ return peerFromPeerId(peers0.get(current().nextInt(peers0.size())));
+ }
+
+ private Peer peerFromPeerId(PeerId peer) {
+ if (peer == null)
+ return null;
+ else
+ return new Peer(NetworkAddress.from(peer.getEndpoint().getIp() +
":" + peer.getEndpoint().getPort()));
+ }
+
+ private List<PeerId> parsePeerList(List<String> peers) {
+ List<PeerId> res = new ArrayList<>(peers.size());
+ for (String peer: peers) {
+ res.add(PeerId.parsePeer(peer));
+ }
+ return res;
+ }
+
+ private List<Peer> convertPeerIdList(List<PeerId> peers) {
+ if (peers == null)
+ return Collections.emptyList();
+
+ List<Peer> res = new ArrayList<>(peers.size());
Review comment:
Empty lines are missing before for and beofre return.
{} for one liner are excessive.
##########
File path:
modules/raft/src/main/java/org/apache/ignite/raft/jraft/rpc/impl/RaftGroupServiceImpl.java
##########
@@ -446,11 +523,37 @@ private boolean recoverable(Throwable t) {
* @return Random node.
*/
private Peer randomNode() {
- List<Peer> peers0 = peers;
+ List<PeerId> peers0 = peers;
if (peers0 == null || peers0.isEmpty())
return null;
- return peers0.get(current().nextInt(peers0.size()));
+ return peerFromPeerId(peers0.get(current().nextInt(peers0.size())));
+ }
+
+ private Peer peerFromPeerId(PeerId peer) {
+ if (peer == null)
+ return null;
+ else
+ return new Peer(NetworkAddress.from(peer.getEndpoint().getIp() +
":" + peer.getEndpoint().getPort()));
+ }
+
+ private List<PeerId> parsePeerList(List<String> peers) {
+ List<PeerId> res = new ArrayList<>(peers.size());
+ for (String peer: peers) {
+ res.add(PeerId.parsePeer(peer));
+ }
+ return res;
+ }
+
+ private List<Peer> convertPeerIdList(List<PeerId> peers) {
Review comment:
javadoc
##########
File path:
modules/raft/src/main/java/org/apache/ignite/raft/jraft/rpc/impl/RaftGroupServiceImpl.java
##########
@@ -446,11 +523,37 @@ private boolean recoverable(Throwable t) {
* @return Random node.
*/
private Peer randomNode() {
- List<Peer> peers0 = peers;
+ List<PeerId> peers0 = peers;
if (peers0 == null || peers0.isEmpty())
return null;
- return peers0.get(current().nextInt(peers0.size()));
+ return peerFromPeerId(peers0.get(current().nextInt(peers0.size())));
+ }
+
+ private Peer peerFromPeerId(PeerId peer) {
+ if (peer == null)
+ return null;
+ else
+ return new Peer(NetworkAddress.from(peer.getEndpoint().getIp() +
":" + peer.getEndpoint().getPort()));
+ }
+
+ private List<PeerId> parsePeerList(List<String> peers) {
Review comment:
javadoc
##########
File path:
modules/raft/src/main/java/org/apache/ignite/raft/jraft/rpc/impl/RaftGroupServiceImpl.java
##########
@@ -446,11 +523,37 @@ private boolean recoverable(Throwable t) {
* @return Random node.
*/
private Peer randomNode() {
- List<Peer> peers0 = peers;
+ List<PeerId> peers0 = peers;
if (peers0 == null || peers0.isEmpty())
return null;
- return peers0.get(current().nextInt(peers0.size()));
+ return peerFromPeerId(peers0.get(current().nextInt(peers0.size())));
+ }
+
+ private Peer peerFromPeerId(PeerId peer) {
Review comment:
javadoc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
