AMashenkov edited a comment on pull request #321: URL: https://github.com/apache/ignite-3/pull/321#issuecomment-915165122
Can anybody explain to me next. We have Peer and PeerId entities and have methods to convert one to another. Seems, they are interchangable. Why some components holds collections Peer (or PeerIs) and then convert whole collection to PeerId (or Peer) in the component methods? This looks insane. 1. Peer peerFromPeerId(PeerId peer) - this is private, but can be static as well, because no context is needed for convertion. 2. PeerId fromPeer(Peer p) - this is static method -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
