kgusakov commented on pull request #321: URL: https://github.com/apache/ignite-3/pull/321#issuecomment-915228311
> Can anybody explain to me next. > We have Peer and PeerId entities and have methods to convert one to another. Seems, they are interchangable. > Why some components holds collections Peer (or PeerIs) and then convert whole collection to PeerId (or Peer) in the component methods? > This looks insane. > > 1. PeerId fromPeer(Peer p) - this is static method > > 2. Peer peerFromPeerId(PeerId peer) - this is private, but can be static as well, because no context is needed for conversion. @AMashenkov It's just a problem of the current solution, where our Peer is a duplicate of PeerId from raft, because we can't use PeerId in raft-client module (raft-server depends on raft-client, but not visa versa). This issue should be fixed I think, but under another ticket. I will create TODO and appropriate jira issue - WDYT? What about 2 - will be fixed here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
