kgusakov commented on a change in pull request #321:
URL: https://github.com/apache/ignite-3/pull/321#discussion_r705294108
##########
File path:
modules/raft/src/main/java/org/apache/ignite/raft/jraft/rpc/RpcResponseFactory.java
##########
@@ -73,4 +73,23 @@ default Message newResponse(RaftMessagesFactory msgFactory,
int code, String fmt
eBuilder.errorMsg(String.format(fmt, args));
return eBuilder.build();
}
+
+ /**
+ * Creates an error response with parameters.
+ *
+ * @param leaderId New leader id
+ * @param msgFactory Raft message factory
+ * @param code error code with raft info
+ * @param fmt message with format string
+ * @param args arguments referenced by the format specifiers in the format
string
+ * @return a response instance
+ */
+ default Message newResponse(String leaderId, RaftMessagesFactory
msgFactory, int code, String fmt, Object... args) {
Review comment:
- Fixed
- Yes
- Will create separate issue about this idea
- Yes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
