timoninmaxim commented on a change in pull request #9313:
URL: https://github.com/apache/ignite/pull/9313#discussion_r708107058
##########
File path:
modules/core/src/test/java/org/apache/ignite/testframework/junits/common/GridCommonAbstractTest.java
##########
@@ -1929,17 +1929,27 @@ protected void assertEqualsCollections(Collection<?>
exp, Collection<?> act) {
}
/**
- *
+ * Cleans persistence directory including snapshots.
*/
protected void cleanPersistenceDir() throws Exception {
+ cleanPersistenceDir(true);
Review comment:
I don't like an idea that we change a signature of this wide used
method. It is extremely rare case to not clean snapshots in tests. What are
alternatives? For example, create snapshots in different directory for tests
that don't clean them, or introduce a method for copy-pasting snapshots. WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
