ibessonov commented on a change in pull request #336:
URL: https://github.com/apache/ignite-3/pull/336#discussion_r710076064
##########
File path:
modules/configuration/src/main/java/org/apache/ignite/internal/configuration/util/ConfigurationNotificationsUtil.java
##########
@@ -250,23 +366,25 @@ public static void notifyListeners(
List<CompletableFuture<?>> futures,
BiFunction<L, ConfigurationNotificationEvent<V>, CompletableFuture<?>>
updater
) {
- ConfigurationNotificationEvent<V> evt = new
ConfigurationNotificationEventImpl<>(
- oldVal,
- newVal,
- storageRevision
- );
+ if (!listeners.isEmpty()) {
Review comment:
Why not just add this?:
if (listeners.isEmpty())
return;
This way code will much easier to read
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
