sanpwc commented on a change in pull request #330:
URL: https://github.com/apache/ignite-3/pull/330#discussion_r710761263
##########
File path:
modules/schema/src/main/java/org/apache/ignite/internal/schema/mapping/ColumnMapper.java
##########
@@ -24,6 +24,7 @@
/**
* Column mapper interface.
*/
+// TODO: IGNITE-15480 Probably should be removed after index column mapping
refactoring.
Review comment:
As was discussed mapping logic was restored:
```
clusterCfgMgr.configurationRegistry()
.getConfiguration(TablesConfiguration.KEY).tables()
.change(ch -> {
ch.createOrUpdate(name, tableChange);
ch.createOrUpdate(name, tblCh ->
((ExtendedTableChange)tblCh).changeSchemas(
schemasCh ->
schemasCh.createOrUpdate(
String.valueOf(schemasCh.size() + 1),
schemaCh -> {
ExtendedTableView currTableView
= (ExtendedTableView)
clusterCfgMgr.configurationRegistry().getConfiguration(TablesConfiguration.KEY).tables().get(name).value();
SchemaDescriptor descriptor =
SchemaUtils.prepareSchemaDescriptor(
((ExtendedTableView)tblCh).schemas().size(),
tblCh
);
descriptor.columnMapping(SchemaUtils.columnMapper(
tablesById.get(tblId).schemaRegistry().schema(currTableView.schemas().size()
-1),
currTableView,
descriptor,
tblCh
));
schemaCh.changeSchema(ByteUtils.toBytes(descriptor));
}
)
));
})
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
