AMashenkov commented on a change in pull request #332: URL: https://github.com/apache/ignite-3/pull/332#discussion_r710880167
########## File path: modules/core/src/main/java/org/apache/ignite/internal/util/IgniteSpinReadWriteLock.java ########## @@ -0,0 +1,406 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.util; + +import java.util.concurrent.TimeUnit; +import org.apache.ignite.internal.tostring.S; + +/** + * Spin read-write lock. + */ +public class IgniteSpinReadWriteLock { + /** */ + private static final long PENDING_WLOCKS_OFFS; + + /** */ + private static final long STATE_OFFS; + + /** + * + */ + static { + try { + STATE_OFFS = GridUnsafe.objectFieldOffset(IgniteSpinReadWriteLock.class.getDeclaredField("state")); + + PENDING_WLOCKS_OFFS = + GridUnsafe.objectFieldOffset(IgniteSpinReadWriteLock.class.getDeclaredField("pendingWLocks")); + } + catch (NoSuchFieldException e) { + throw new Error(e); + } Review comment: AFAIK, we thought to replace Unsafe usage with VarHandle where it is possible. JDK developers claims that "static final" VarHandles have no performance penalty in opposite to non-static/non-final one, which may have slightly noticible additional cost. "static final" VarHandle will covers this case. Would you mind to do it or create a separate ticket? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
