AMashenkov commented on a change in pull request #355:
URL: https://github.com/apache/ignite-3/pull/355#discussion_r714076047
##########
File path:
modules/client/src/main/java/org/apache/ignite/jdbc/IgniteJdbcDriver.java
##########
@@ -107,7 +107,7 @@
* @return Driver instance.
* @throws RuntimeException when failed to register driver.
*/
- public static synchronized Driver register() {
+ private static synchronized Driver register() {
Review comment:
```suggestion
private static synchronized void register() {
```
##########
File path:
modules/client/src/main/java/org/apache/ignite/jdbc/IgniteJdbcDriver.java
##########
@@ -107,7 +107,7 @@
* @return Driver instance.
* @throws RuntimeException when failed to register driver.
*/
- public static synchronized Driver register() {
+ private static synchronized Driver register() {
Review comment:
Let's drop 'registered' flag and make instance non-final.
See:
https://github.com/pgjdbc/pgjdbc/blob/master/pgjdbc/src/main/java/org/postgresql/Driver.java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
