AMashenkov commented on a change in pull request #353:
URL: https://github.com/apache/ignite-3/pull/353#discussion_r715702029



##########
File path: 
modules/table/src/main/java/org/apache/ignite/internal/table/KeyValueViewImpl.java
##########
@@ -47,8 +47,8 @@
      * @param valueMapper Value class mapper.
      * @param tx The transaction.
      */
-    public KVViewImpl(InternalTable tbl, SchemaRegistry schemaReg, 
KeyMapper<K> keyMapper,
-        ValueMapper<V> valueMapper, @Nullable Transaction tx) {
+    public KeyValueViewImpl(InternalTable tbl, SchemaRegistry schemaReg, 
KeyMapper<K> keyMapper,

Review comment:
       They are useless for binary views.
   These mappers describes how columns should be mapped to user POJO fields.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to