denis-chudov commented on a change in pull request #9327:
URL: https://github.com/apache/ignite/pull/9327#discussion_r717620455
##########
File path:
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/IgniteCacheOffheapManager.java
##########
@@ -89,16 +88,28 @@
*/
public void stop();
+ /**
+ * Pre-create single partition that resides in page memory or WAL and
restores their state.
+ *
+ * @param p Partition id.
+ * @param recoveryState Partition recovery state.
+ * @return Processing time in millis.
+ * @throws IgniteCheckedException If failed.
+ */
+ long restoreStateOfPartition(int p, @Nullable Integer recoveryState)
throws IgniteCheckedException;
Review comment:
too similar to `restorePartitionStates`
##########
File path:
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/IgniteCacheOffheapManager.java
##########
@@ -89,16 +88,28 @@
*/
public void stop();
+ /**
+ * Pre-create single partition that resides in page memory or WAL and
restores their state.
+ *
+ * @param p Partition id.
+ * @param recoveryState Partition recovery state.
+ * @return Processing time in millis.
+ * @throws IgniteCheckedException If failed.
+ */
+ long restoreStateOfPartition(int p, @Nullable Integer recoveryState)
throws IgniteCheckedException;
+
/**
* Pre-create partitions that resides in page memory or WAL and restores
their state.
*
- * @param partRecoveryStates Partition recovery states.
- * @return Processed partitions: partition id -> processing time in millis.
* @throws IgniteCheckedException If failed.
*/
- Map<Integer, Long> restorePartitionStates(
- Map<GroupPartitionId, Integer> partRecoveryStates
- ) throws IgniteCheckedException;
+ void restorePartitionStates() throws IgniteCheckedException;
+
+ /**
+ * Confirm that partition states are restored. This method should be
called after restoring state of all partitions
+ * in group using {@link #restoreStateOfPartition(int, Integer)}.
+ */
+ void confirmPartitionStatesRestored();
Review comment:
I am not sure - current method name completely matches with what it does
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
