sanpwc commented on a change in pull request #379:
URL: https://github.com/apache/ignite-3/pull/379#discussion_r724073014



##########
File path: 
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/TableManager.java
##########
@@ -824,4 +885,141 @@ private void dropTableLocally(String name, IgniteUuid 
tblId, List<List<ClusterNo
     private boolean isTableConfigured(String name) {
         return tableNamesConfigured().contains(name);
     }
+
+    public void setBaseline(Set<String> nodes) {
+        var newAssignments = baselineMgr

Review comment:
       It worth to mention here, why we only choose of existing nodes and do 
not update an assignment later on when new nodes appeared that do match 
specified baseline.Though it's not a part of current approach, it worth to 
mention it in code.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to