sanpwc commented on a change in pull request #388:
URL: https://github.com/apache/ignite-3/pull/388#discussion_r725966082
##########
File path:
modules/table/src/main/java/org/apache/ignite/internal/table/IgniteTablesInternal.java
##########
@@ -30,4 +31,12 @@
* @return Table or {@code null} when not exists.
*/
TableImpl table(IgniteUuid id);
+
+ /**
+ * Gets a table future by id, if it was created before or {@code null}.
+ *
+ * @param id Table id.
+ * @return Future representing pending completion of the operation.
+ */
+ CompletableFuture<TableImpl> tableAsync(IgniteUuid id);
Review comment:
Seems that we should also specify possible exceptions here.
>or {@code null}.
Do you mean that we'll get null instead of future future.get will return
null?
##########
File path:
modules/table/src/main/java/org/apache/ignite/internal/table/IgniteTablesInternal.java
##########
@@ -30,4 +31,12 @@
* @return Table or {@code null} when not exists.
*/
TableImpl table(IgniteUuid id);
+
+ /**
+ * Gets a table future by id, if it was created before or {@code null}.
+ *
+ * @param id Table id.
+ * @return Future representing pending completion of the operation.
+ */
+ CompletableFuture<TableImpl> tableAsync(IgniteUuid id);
Review comment:
Seems that we should also specify possible exceptions here.
>or {@code null}.
Do you mean that we'll get null instead of future future.get will return
null?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
