timoninmaxim commented on a change in pull request #9081:
URL: https://github.com/apache/ignite/pull/9081#discussion_r726938937
##########
File path:
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/query/GridCacheDistributedQueryManager.java
##########
@@ -523,57 +488,27 @@ else if (!cancelled.contains(res.requestId()))
}
/** {@inheritDoc} */
- @SuppressWarnings("unchecked")
@Override public CacheQueryFuture<?> queryDistributed(GridCacheQueryBean
qry, final Collection<ClusterNode> nodes) {
+ return queryDistributed(qry, nodes, false);
+ }
+
+ /** */
+ private CacheQueryFuture<?> queryDistributed(GridCacheQueryBean qry, final
Collection<ClusterNode> nodes, boolean fields) {
Review comment:
I don't like this idea, we make all actions on future within this
method, there is no need to create a future in separate method. Also it is
required to create `reqId` for both cases, so code duplication will appear.
Let's save this logic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
