AMashenkov commented on a change in pull request #401:
URL: https://github.com/apache/ignite-3/pull/401#discussion_r730996809
##########
File path:
modules/schema/src/main/java/org/apache/ignite/internal/schema/Column.java
##########
@@ -24,15 +24,20 @@
import org.jetbrains.annotations.NotNull;
/**
- * Column description for a type schema. Column contains a column name, a
column type and a nullability flag.
+ * Column descriptor which contains a column name, a type and a nullability
flag.
* <p>
* Column instances are comparable in lexicographic order, native type first
and then column name. Nullability
Review comment:
We have to write a row in a specific order: key first, then value and
fixlen columns first, then varlen.
The order must be same for all the nodes.
So, we must compare native type first, then column names.
Also, compareTo must be consistent with the equals. Thus columnOrder can't
be used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
