sanpwc commented on a change in pull request #399:
URL: https://github.com/apache/ignite-3/pull/399#discussion_r732490224
##########
File path:
modules/table/src/main/java/org/apache/ignite/internal/table/InternalTable.java
##########
@@ -33,7 +34,22 @@
* Internal table facade provides low-level methods for table operations.
* The facade hides TX/replication protocol over table storage abstractions.
*/
-public interface InternalTable {
+public interface InternalTable extends AutoCloseable {
+ /**
+ * Gets a storage for the table.
+ *
+ * @return Table storage.
+ */
+ @NotNull TableStorage storage();
+
+ /**
+ * Updates internal table raft group service for given partition.
+ *
+ * @param p Partition.
+ * @param raftGrpSvc Raft group service.
+ */
+ void updateInternalTableRaftGroupService(int p, RaftGroupService
raftGrpSvc);
Review comment:
Same is above. How it's related to TableManager.stop()?
updateInternalTableRaftGroupService is an ugly hopefully temporary hack that
shouldn't be exposed to an interface, especially an interface that
**The facade hides TX/replication protocol over table storage
abstractions**. I mean that it's explicitly specified that InternalTable
interface should hide replication protocol, so it definitely shouldn't have
updateRaftGroup methods that are internal part of replication protocol.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
