sanpwc commented on a change in pull request #399:
URL: https://github.com/apache/ignite-3/pull/399#discussion_r732673570
##########
File path:
modules/table/src/main/java/org/apache/ignite/internal/table/TableImpl.java
##########
@@ -113,13 +111,8 @@ public void schemaMode(SchemaManagementMode schemaMode) {
this.tbl.schema(schemaMode);
}
- /**
- * Updates internal table raft group service for given partition.
- *
- * @param p Partition.
- * @param raftGrpSvc Raft group service.
- */
- public void updateInternalTableRaftGroupService(int p, RaftGroupService
raftGrpSvc) {
- ((InternalTableImpl)tbl).updateInternalTableRaftGroupService(p,
raftGrpSvc);
+ /** {@inheritDoc} */
+ @Override public void close() throws Exception {
+ tbl.close();
Review comment:
It seems to be a bit messy: tbl in an external resource that is created
somewhere outside TableImpl, so it either should be closed where it was created
or created inside TableImpl.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
