sanpwc commented on a change in pull request #399:
URL: https://github.com/apache/ignite-3/pull/399#discussion_r732781398
##########
File path:
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/storage/InternalTableImpl.java
##########
@@ -99,6 +99,9 @@
/** Table schema mode. */
private volatile SchemaManagementMode schemaMode;
+ /** Storage for table data. */
+ private final TableStorage tableStorage;
Review comment:
Hmm, I'm not sure that's it's a good idea. tableStorage doesn't used for
business related logic inside InternalTable. It's created and started within
TableManager, also all stuff like tableStorage.getOrCreatePartition goes inside
tableManager.
As was mentioned earlier, from my point of view it's not a good idea to
close it here ignoring the fact that it was created externally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
