xtern commented on a change in pull request #9444:
URL: https://github.com/apache/ignite/pull/9444#discussion_r736581438
##########
File path:
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/snapshot/IgniteSnapshotManager.java
##########
@@ -875,6 +875,23 @@ public boolean isSnapshotCreating() {
}
}
+ /**
+ * @return Snapshot name if the snapshot create operation is in progress
or {@code null}.
+ */
+ protected @Nullable String getCreatingSnapshotName() {
Review comment:
How about combining `getCreatingSnapshotName` and
`getRestoringSnapshotName` into a single `status()` method, and move the
relevant code from the job to the `status()`?
##########
File path:
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/snapshot/IgniteSnapshotManager.java
##########
@@ -1732,12 +1766,12 @@ static void copy(FileIOFactory factory, File from, File
to, long length) {
}
/**
- * @param taskCls Snapshot restore operation management task class.
- * @param snpName Snapshot name.
+ * @param taskCls Snapshot operation management task class.
+ * @param arg Task argument.
*/
- private IgniteFuture<Boolean> executeRestoreManagementTask(
- Class<? extends ComputeTask<String, Boolean>> taskCls,
- String snpName
+ private <K, V> IgniteFuture<V> executeSnapshotManagementTask(
Review comment:
K, V is for key-value, use T, S instead
https://docs.oracle.com/javase/tutorial/java/generics/types.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
