sanpwc commented on a change in pull request #400:
URL: https://github.com/apache/ignite-3/pull/400#discussion_r737683382
##########
File path:
modules/client-handler/src/main/java/org/apache/ignite/client/handler/requests/table/ClientTableCommon.java
##########
@@ -190,10 +191,11 @@ public static void writeTuple(
*
* @param packer Packer.
* @param tuples Tuples.
+ * @param schemaRegistry The registry.
* @throws IgniteException on failed serialization.
*/
- public static void writeTuples(ClientMessagePacker packer,
Collection<Tuple> tuples) {
- writeTuples(packer, tuples, TuplePart.KEY_AND_VAL);
+ public static void writeTuples(ClientMessagePacker packer,
Collection<Tuple> tuples, SchemaRegistry schemaRegistry) {
Review comment:
Why we need schemaRegistry on client side? What's the protocol of
updating it? In other words, how do the client finds out that schema was
changed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
