AMashenkov commented on a change in pull request #410:
URL: https://github.com/apache/ignite-3/pull/410#discussion_r738641603
##########
File path:
modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/exec/ExecutionServiceImpl.java
##########
@@ -579,11 +583,28 @@ private void register(QueryInfo info) {
}
/** */
- private FieldsMetadata queryFieldsMetadata(PlanningContext ctx,
RelDataType sqlType,
+ private ResultSetMetadataInternal resultSetMetadata(PlanningContext ctx,
RelDataType sqlType,
@Nullable List<List<String>> origins) {
RelDataType resultType = TypeUtils.getResultType(
ctx.typeFactory(), ctx.catalogReader(), sqlType, origins);
- return new FieldsMetadataImpl(resultType, origins);
+
+ List<ResultFieldMetadata> fields = new
ArrayList<>(resultType.getFieldCount());
+
+ for (int i = 0; i < resultType.getFieldCount(); ++i) {
Review comment:
Does it make sense to iterate over collection lazily? only when
ResulSetMetadata.fields() is called?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
