ptupitsyn commented on a change in pull request #434:
URL: https://github.com/apache/ignite-3/pull/434#discussion_r746796775
##########
File path:
modules/client-handler/src/integrationTest/java/org/apache/ignite/client/handler/ItClientHandlerTest.java
##########
@@ -167,7 +167,7 @@ void testHandshakeInvalidVersionReturnsError() throws
Exception {
final var err = unpacker.unpackString();
assertArrayEquals(MAGIC, magic);
- assertEquals(31, len);
+ assertEquals(32, len);
Review comment:
Yes, this is compatible. We can use bigger varint format even if the
number if small (e.g. number 5 can be encoded as 1 byte, but it is allowed to
use 2-byte or 4-byte formats too).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
