ascherbakoff commented on a change in pull request #426:
URL: https://github.com/apache/ignite-3/pull/426#discussion_r751212033
##########
File path:
modules/raft/src/main/java/org/apache/ignite/raft/jraft/util/timer/DefaultTimer.java
##########
@@ -91,7 +91,7 @@ public boolean isCancelled() {
@Override
public boolean cancel() {
final ScheduledFuture<?> f = future;
- return f != null && f.cancel(true);
+ return f != null && f.cancel(false); // Avoid interrupting
thread in the pool.
Review comment:
To avoid interruption of threads in the pool (which is shared)
Produces side effects like abnormal timer task termination (for example,
caused by ClosedByInterruptException)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
