ptupitsyn commented on a change in pull request #9526: URL: https://github.com/apache/ignite/pull/9526#discussion_r753119604
########## File path: modules/platforms/dotnet/Apache.Ignite.Core/Services/IServiceCallContext.cs ########## @@ -0,0 +1,75 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +namespace Apache.Ignite.Core.Services +{ + /// <summary> + /// Represents service call context. + /// <para /> + /// This context is implicitly passed to the service and can be retrieved inside the service + /// using <see cref="IServiceContext.CurrentCallContext()"/>. It is accessible only + /// from the local thread during the execution of a service method. + /// <para /> + /// Use <see cref="ServiceCallContextBuilder"/> to instantiate the context. + /// <para /> + /// <b>Note</b>: passing the context to the service may lead to performance overhead, + /// so it should only be used for "middleware" tasks. + /// <para /> + /// Usage example: + /// <code> + /// // Service implementation. + /// public class HelloServiceImpl : HelloService + /// { + /// private IServiceContext ctx; + /// + /// public void Init(IServiceContext ctx) + /// { + /// this.ctx = ctx; + /// } + /// + /// public string Call(string msg) + /// { + /// return msg + ctx.CurrentCallContext.Attribute("user"); + /// } + /// ... + /// } + /// ... + /// + /// // Call this service with context. + /// IServiceCallContext callCtx = new ServiceCallContextBuilder().Set("user", "John").build(); + /// HelloService helloSvc = ignite.GetServices().GetServiceProxy<HelloService>("hello-service", false, callCtx); + /// // Print "Hello John". + /// Console.WriteLine( helloSvc.call("Hello ") ); + /// </code> + /// </summary> + public interface IServiceCallContext Review comment: Should we mark this `[IgniteExperimental]` too? ########## File path: modules/platforms/dotnet/Apache.Ignite.Core/Services/ServiceCallContextBuilder.cs ########## @@ -0,0 +1,78 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +namespace Apache.Ignite.Core.Services +{ + using System; + using System.Collections; + using System.Linq; + using Apache.Ignite.Core.Impl.Common; + using Apache.Ignite.Core.Impl.Services; + + /// <summary> + /// Service call context builder. + /// </summary> + public class ServiceCallContextBuilder + { + /** Context attributes. */ + private readonly Hashtable _attrs = new Hashtable(); + + /// <summary> + /// Set string attribute. + /// </summary> + /// <param name="name">Attribute name.</param> + /// <param name="value">Attribute value.</param> + /// <returns>This for chaining.</returns> + public ServiceCallContextBuilder Set(string name, string value) + { + IgniteArgumentCheck.NotNullOrEmpty(name, "name"); + IgniteArgumentCheck.NotNull(value, "value"); + + _attrs[name] = value; + + return this; + } + + /// <summary> + /// Set binary attribute. + /// </summary> + /// <param name="name">Attribute name.</param> + /// <param name="value">Attribute value.</param> + /// <returns>This for chaining.</returns> + public ServiceCallContextBuilder Set(string name, byte[] value) + { + IgniteArgumentCheck.NotNullOrEmpty(name, "name"); + IgniteArgumentCheck.NotNull(value, "value"); + + _attrs[name] = value.ToArray(); Review comment: Do we really need a defensive copy there? Allocating arrays and cleaning them up is expensive, especially for large ones. I think we can use the original instance and add a comment. If the user intends to change the array after adding it here, they can do the copy manually. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
