Berkof commented on a change in pull request #452:
URL: https://github.com/apache/ignite-3/pull/452#discussion_r753954849
##########
File path:
modules/schema/src/test/java/org/apache/ignite/internal/schema/marshaller/RecordMarshallerTest.java
##########
@@ -424,9 +424,9 @@ public void ensureAllTypesChecked() {
new Column("primitiveByteCol", INT8, false, () -> (byte) 0x42),
new Column("primitiveShortCol", INT16, false, () -> (short)
0x4242),
new Column("primitiveIntCol", INT32, false, () -> 0x42424242),
- new Column("primitiveFloatCol", FLOAT, false),
- new Column("primitiveDoubleCol", DOUBLE, false),
-
+ new Column("primitiveFloatCol", FLOAT, false, () -> 100.100),
Review comment:
Unnecessary change, reverted.
##########
File path:
modules/schema/src/test/java/org/apache/ignite/internal/schema/serializer/AbstractSerializerTest.java
##########
@@ -88,14 +88,14 @@ public void columnOrderSerializeTest() {
AbstractSchemaSerializer assembler = SchemaSerializerImpl.INSTANCE;
Column[] keyCols = {
- new Column(0, "A", NativeTypes.UUID, false, () -> null),
- new Column(1, "B", NativeTypes.INT64, false, () -> null),
- new Column(2, "C", NativeTypes.INT8, false, () -> null),
+ new Column(0, "A", NativeTypes.UUID, false, null),
Review comment:
To use static null value supplier.
##########
File path:
modules/schema/src/main/java/org/apache/ignite/internal/schema/marshaller/reflection/Marshaller.java
##########
@@ -215,6 +232,10 @@ public Object readObject(Row reader) throws
MarshallerException {
@Override
public void writeObject(Object obj, RowAssembler writer)
throws MarshallerException {
+ if (readOnly) {
Review comment:
Read only logic removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
