AMashenkov commented on a change in pull request #326: URL: https://github.com/apache/ignite-3/pull/326#discussion_r754376006
########## File path: modules/api/src/main/java/org/apache/ignite/sql/async/AsyncResultSet.java ########## @@ -0,0 +1,76 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.sql.async; + +import java.util.concurrent.CompletionStage; +import org.apache.ignite.sql.ResultSetMetadata; +import org.apache.ignite.sql.SqlRow; + +/** + * Asynchronous result set. + */ +public interface AsyncResultSet { + /** + * Returns metadata for the results. + * + * @return ResultSet metadata. + */ + ResultSetMetadata metadata(); + + /** + * Returns whether the result set contains rows (SELECT query result), or not (for query of DML, DDL or other kind). + * + * @return {@code True} if result set contains rows, {@code false} otherwise. + */ + boolean hasRowSet(); + + /** + * Returns number of row affected by DML query. + * + * @return Number of rows. + */ + int updateCount(); + + /** + * Returns result for the conditional query. + * + * @return {@code True} if conditional query applied, {@code false} otherwise. + */ + boolean wasApplied(); + + /** + * Returns the current page content. + * + * @return Iterable over rows. + */ + Iterable<SqlRow> currentPage(); Review comment: We assumed that underneath, the data will be pulled page-by-page from a server (like in Ignite 2). Page size can be configured in Session via session properties because it is an advanced option. Maybe it make sense to add API method to control page size for Async case, due to AsyncResultSet already offer page-based contract. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
