rpuch commented on a change in pull request #467:
URL: https://github.com/apache/ignite-3/pull/467#discussion_r756124935
##########
File path:
modules/configuration/src/main/java/org/apache/ignite/internal/configuration/asm/ConfigurationAsmGenerator.java
##########
@@ -1238,6 +1238,8 @@ private void addNodeConstructMethod(
FieldDefinition fieldDef = fieldDefs.get(fieldName);
if (isPolymorphicId(schemaField)) {
+
makeSureChangePolymorphicTypeIdMethodIsDefined(changePolymorphicTypeIdMtd,
schemaField);
Review comment:
The assertion is that `changePolymorphicTypeIdMtd` is not `null` when we
are going to use it. This variable is not yet in scope on line 395. It appears
later.
Even if I create a validation on line 395, `changePolymorphicTypeIdMtd`
usage is so far away that the assertion will still be needed. And the
validation is actually made in other class (`ConfigurationRegistry`).
Do you want me to create a validation close to line 395 and remove the
assertion?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
