alex-plekhanov commented on a change in pull request #9601: URL: https://github.com/apache/ignite/pull/9601#discussion_r756792854
########## File path: modules/calcite/src/test/java/org/apache/ignite/internal/processors/query/calcite/integration/CorrelatesIntegrationTest.java ########## @@ -0,0 +1,54 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.processors.query.calcite.integration; + +import org.apache.ignite.internal.processors.query.calcite.QueryChecker; +import org.junit.Test; + +/** + * Test correlated queries. + */ +public class CorrelatesIntegrationTest extends AbstractBasicIntegrationTest { + /** + * Checks correlates are assigned before access. + */ + @Test + public void testCorrelatesAssignedBeforeAccess() { + sql("create table test_tbl(v INTEGER)"); + sql("INSERT INTO test_tbl VALUES (1)"); + + assertQuery("SELECT t0.v, (SELECT t0.v + t1.v FROM test_tbl t1) AS j FROM test_tbl t0") + .returns(1, 2) + .check(); + } + + /** + * Check that correlates can't be moved under the table spool. + */ + @Test + public void testCorrelatesWithTableSpool() { + sql("CREATE TABLE test(i1 INT, i2 INT)"); + sql("INSERT INTO test VALUES (1, 1), (2, 2)"); + + assertQuery("SELECT (SELECT t1.i1 + t1.i2 + t0.i2 FROM test t1 WHERE i1 = 1) FROM test t0") + .matches(QueryChecker.containsSubPlan("IgniteTableSpool")) Review comment: For certain node positions, planner tests should be added. Current integration tests just do primitive checks. Here if the position of the table spool will be changed, will get the wrong result, so I think nothing wrong here with the current check. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
