ascherbakoff commented on a change in pull request #400:
URL: https://github.com/apache/ignite-3/pull/400#discussion_r756810595
##########
File path:
modules/client-handler/src/main/java/org/apache/ignite/client/handler/requests/table/ClientTableCommon.java
##########
@@ -190,10 +191,11 @@ public static void writeTuple(
*
* @param packer Packer.
* @param tuples Tuples.
+ * @param schemaRegistry The registry.
* @throws IgniteException on failed serialization.
*/
- public static void writeTuples(ClientMessagePacker packer,
Collection<Tuple> tuples) {
- writeTuples(packer, tuples, TuplePart.KEY_AND_VAL);
+ public static void writeTuples(ClientMessagePacker packer,
Collection<Tuple> tuples, SchemaRegistry schemaRegistry) {
Review comment:
schemaRegistry provides schema version, which is required by client
serialization protocol to deserialize tuples.
org.apache.ignite.client.handler.requests.table.ClientTableCommon#readTuple(org.apache.ignite.internal.client.proto.ClientMessageUnpacker,
boolean, org.apache.ignite.internal.schema.SchemaDescriptor)
I would avoid discussing schemas in this pr, because this is not the scope
of the pr.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
