ptupitsyn commented on a change in pull request #9610:
URL: https://github.com/apache/ignite/pull/9610#discussion_r757599200
##########
File path:
modules/core/src/main/java/org/apache/ignite/internal/processors/odbc/ClientMessage.java
##########
@@ -35,6 +35,18 @@
/** */
private static final long serialVersionUID = -4609408156037304495L;
+ /** */
+ private static final int MAX_HANDSHAKE_SIZE = 1024 * 1024;
Review comment:
We should pick a limit and stick to it. Update documentation and state
that everything else is not supported.
Current limit is essentially **2 GiB**, but having a password or user
attributes this large does not make sense, and may cause all sorts of
performance issues.
If **1 MiB** is too low, let's pick **10 MiB** or **64 MiB**, but no more
than that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
