ascherbakoff commented on a change in pull request #9362:
URL: https://github.com/apache/ignite/pull/9362#discussion_r760040930
##########
File path:
modules/control-utility/src/main/java/org/apache/ignite/internal/commandline/TxCommands.java
##########
@@ -138,8 +139,12 @@ else if (args.getOperation() == VisorTxOperation.KILL)
", consistentId=" + key.consistentId() +
"]");
- for (VisorTxInfo info : entry.getValue().getInfos())
- logger.info(info.toUserString());
+ for (VisorTxInfo info : entry.getValue().getInfos()) {
+ if (Objects.equals(info.getXid(), info.getNearXid()))
+ logger.info(info.toUserString());
+ else
+ logger.info(info.toUserString() + " [Near node may be
missed]");
+ }
Review comment:
This is true. I suggest to collect only near transactions if non verbose
mode.
##########
File path:
modules/control-utility/src/main/java/org/apache/ignite/internal/commandline/TxCommands.java
##########
@@ -138,8 +139,12 @@ else if (args.getOperation() == VisorTxOperation.KILL)
", consistentId=" + key.consistentId() +
"]");
- for (VisorTxInfo info : entry.getValue().getInfos())
- logger.info(info.toUserString());
+ for (VisorTxInfo info : entry.getValue().getInfos()) {
+ if (Objects.equals(info.getXid(), info.getNearXid()))
+ logger.info(info.toUserString());
+ else
+ logger.info(info.toUserString() + " [Near node may be
missed]");
Review comment:
This message is not correct. The meaning of this branch condition - we
are printing a non-near (local or remote) transaction. It has no relation to a
presence of a node in the cluster.
##########
File path:
modules/core/src/main/java/org/apache/ignite/internal/visor/tx/VisorTxTask.java
##########
@@ -173,21 +179,22 @@
it.remove();
}
}
+
+ if (infos.size() > limit)
+ infos.subList(limit, infos.size()).clear();
}
}
return mapRes;
}
- /**
- *
- */
+ /** */
private static class VisorTxJob extends VisorJob<VisorTxTaskArg,
VisorTxTaskResult> {
/** */
private static final long serialVersionUID = 0L;
/** */
- private static final int DEFAULT_LIMIT = 50;
+ private static final int DEFAULT_MAP_LIMIT = 50;
Review comment:
The limit should be applied only on reducer side and removed from map
side. Transactions should be streamed to reducer in batches using continous
mapping to avoid memory issues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
