AMashenkov commented on a change in pull request #484:
URL: https://github.com/apache/ignite-3/pull/484#discussion_r762069392
##########
File path:
modules/api/src/main/java/org/apache/ignite/schema/definition/builder/PrimaryKeyDefinitionBuilder.java
##########
@@ -39,6 +48,14 @@
*/
PrimaryKeyDefinitionBuilder withColumns(String... columns);
+ /**
+ * Sets primary key columns.
+ *
+ * @param columns Indexed columns.
+ * @return {@code this} for chaining.
+ */
+ PrimaryKeyDefinitionBuilder withColumns(Set<String> columns);
Review comment:
Are we going to build an index on primary key implicitly?
Undefined column order will restrict us here.
Assume, user can do next via SQL and how to do the same via config API?
```
CREATE TABLE t (
id1 INT,
id2 INT
) PRIMARY_KEY(id2, id1);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
