ptupitsyn commented on a change in pull request #9612: URL: https://github.com/apache/ignite/pull/9612#discussion_r763062896
########## File path: modules/core/src/main/java/org/apache/ignite/configuration/SystemDataRegionConfiguration.java ########## @@ -0,0 +1,93 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.ignite.configuration; + +import java.io.Serializable; +import org.apache.ignite.internal.util.typedef.internal.A; + +/** + * This class allows defining system data region configuration with various parameters for Apache Ignite + * page memory (see {@link DataStorageConfiguration}. + * This class is similiar to {@link DataRegionConfiguration}, but with restricted set of properties. + */ +public class SystemDataRegionConfiguration implements Serializable { + /** Serial version uid. */ + private static final long serialVersionUID = 0L; + + /** Default initial size of a memory chunk for the system cache (40 MB). */ + private static final long DFLT_SYS_REG_INIT_SIZE = 40L * 1024 * 1024; Review comment: I think those constants should be public (for example, see default values in `IgniteConfiguration` class). ########## File path: modules/platforms/dotnet/Apache.Ignite.Core/Configuration/DataStorageConfiguration.cs ########## @@ -478,13 +491,37 @@ internal void Write(IBinaryRawWriter writer) /// Gets or sets the size of a memory chunk reserved for system needs. /// </summary> [DefaultValue(DefaultSystemRegionInitialSize)] - public long SystemRegionInitialSize { get; set; } Review comment: We should totally use `[Obsolete]` attribute for deprecated APIs. Yes, we would have to suppress compiler warnings when using those APIs - that's the whole point of the attribute, to get a warning. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
