AMashenkov commented on a change in pull request #484:
URL: https://github.com/apache/ignite-3/pull/484#discussion_r764662874
##########
File path:
modules/api/src/main/java/org/apache/ignite/lang/IndexNotFoundException.java
##########
@@ -0,0 +1,16 @@
+package org.apache.ignite.lang;
+
+/**
+ * Exception is thrown when appropriate index is not found.
+ */
+public class IndexNotFoundException extends IgniteException {
+ /**
+ * Create a new exception with given index name.
+ *
+ * @param name Column name.
+ * @param fullName Schema and table name.
+ */
+ public IndexNotFoundException(String name, String fullName) {
Review comment:
```suggestion
* @param indexName Index name.
* @param tableName Table canonical name.
*/
public IndexNotFoundException(String indexName, String tableName) {
```
I think it still not correct because, regarding the SQL standard, index has
it's own canonical name, which doesn't contain table name.
I wonder the index is top-level entity, but that's it.
Maybe the correct way is left just single parameter "indexName", but mention
that a full canonical name is expected here. Like this:
```suggestion
* @param indexName Index canonical name.
*/
public IndexNotFoundException(String indexName) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
