rpuch commented on a change in pull request #495: URL: https://github.com/apache/ignite-3/pull/495#discussion_r764918771
########## File path: modules/network/src/main/java/org/apache/ignite/internal/network/serialization/ClassDescriptorParserContext.java ########## @@ -0,0 +1,126 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.network.serialization; + +import java.util.Collection; +import java.util.concurrent.ConcurrentHashMap; +import java.util.concurrent.ConcurrentMap; +import java.util.concurrent.atomic.AtomicInteger; +import org.apache.ignite.internal.network.serialization.DefaultClassDescriptors.DefaultType; +import org.jetbrains.annotations.Nullable; + +/** + * Class parser context. + */ +public class ClassDescriptorParserContext { + /** Sequential id generator for class descriptors. */ + private final AtomicInteger idGenerator = new AtomicInteger(100); + + /** Map class -> descriptor id. */ + private final ConcurrentMap<Class<?>, Integer> idMap = new ConcurrentHashMap<>(); + + /** Map descriptor id -> class descriptor. */ + private final ConcurrentMap<Integer, ClassDescriptor> descriptorMap = new ConcurrentHashMap<>(); + + /** + * Constructor. + */ + public ClassDescriptorParserContext() { + for (DefaultType value : DefaultType.values()) { + ClassDescriptor defaultDescriptor = DefaultClassDescriptors.createDefaultDescriptor( + value); + + addPredefinedDescriptor(value.clazz(), defaultDescriptor); + } + } + + /** + * Adds predefined class descriptor with a statically configured id. + * + * @param clazz Class. + * @param descriptor Descriptor. + */ + private void addPredefinedDescriptor(Class<?> clazz, ClassDescriptor descriptor) { + int descriptorId = descriptor.descriptorId(); + + Integer existingId = idMap.put(clazz, descriptorId); + + assert existingId == null; Review comment: Well, `should not` sometimes means `still does` :) The problem is that we can never be sure that our tests are checking all the possible cases. That's why it seems to make sense to still leave such checks even in production code. This concrete code will never get hot, so the performance should not be an issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
