AMashenkov commented on a change in pull request #497:
URL: https://github.com/apache/ignite-3/pull/497#discussion_r765636467
##########
File path: modules/api/src/main/java/org/apache/ignite/table/mapper/Mapper.java
##########
@@ -26,6 +28,10 @@
* @param <T> Mapped type.
*/
public interface Mapper<T> {
+ /** Identity mapper cache. */
+ @SuppressWarnings("rawtypes")
+ static final Map<Class, IdentityMapper> identityMappers = new
ConcurrentHashMap<>();
Review comment:
This is public API class that is used as on client-side as on
server-side.
On client-side, this cache is ok for most use cases, because amount of user
domain classes is limited.
But on-server side, user may want to use table views with mappers, but
classes may be deployed temporary for compute purposes.
Thus, cache can be bloated.
Let's move mapper caching to a separate task.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
