ptupitsyn commented on a change in pull request #9628:
URL: https://github.com/apache/ignite/pull/9628#discussion_r766465040
##########
File path:
modules/platforms/dotnet/Apache.Ignite.Core/Impl/Services/ServiceProxyInvoker.cs
##########
@@ -102,6 +102,12 @@ internal static class ServiceProxyInvoker
methodName, svcType, argsLength));
// 2) There is more than 1 method with specified name - resolve
with argument types.
+ methods = methods.Where(m => AreMethodArgsCompatible(arguments,
m.GetParameters(), true)).ToArray();
Review comment:
Now I understand, we attempt a more strict check to reduce ambiguity.
Can you please rename `checkEq` to `strictTypeCheck` and invert the logic?
Right now we perform equality check when `checkEq = false`, which is confusing.
##########
File path:
modules/platforms/dotnet/Apache.Ignite.Core/Impl/Services/ServiceProxyInvoker.cs
##########
@@ -102,6 +102,12 @@ internal static class ServiceProxyInvoker
methodName, svcType, argsLength));
// 2) There is more than 1 method with specified name - resolve
with argument types.
+ methods = methods.Where(m => AreMethodArgsCompatible(arguments,
m.GetParameters(), true)).ToArray();
Review comment:
And let's add a condition to make it clear that we try to resolve
ambiguity here:
```suggestion
if (methods.Length > 1)
methods = methods.Where(m => AreMethodArgsCompatible(arguments,
m.GetParameters(), true)).ToArray();
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
