SammyVimes commented on a change in pull request #490:
URL: https://github.com/apache/ignite-3/pull/490#discussion_r765801736
##########
File path:
modules/configuration/src/main/java/org/apache/ignite/internal/configuration/DynamicProperty.java
##########
@@ -36,33 +38,43 @@
/** Value cannot be changed. */
private final boolean readOnly;
+ /** Configuration field with {@link InjectedName}. */
+ private final boolean injectedNameField;
+
/**
* Constructor.
*
- * @param prefix Property prefix.
- * @param key Property name.
- * @param rootKey Root key.
- * @param changer Configuration changer.
+ * @param prefix Property prefix.
Review comment:
AFAIU, parameters' descriptions should be aligned
##########
File path: modules/configuration/README.md
##########
@@ -163,6 +163,10 @@ public static class DatetimeColumnConfigurationSchema
extends ColumnConfiguratio
Thus, a column can only be one of these (varchar, decimal and datetime) types
and will contain the
type, name and fields specific to it.
+### Additional annotations
+
+* `@InjectedName` - allows to get the key associated with the configuration in
the named list, see javadoc for details.
+
Review comment:
`@Name` should be here too, probably
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
