ptupitsyn commented on a change in pull request #455: URL: https://github.com/apache/ignite-3/pull/455#discussion_r767745590
########## File path: modules/api/src/main/java/org/apache/ignite/table/mapper/PojoMapper.java ########## @@ -0,0 +1,46 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.table.mapper; + +import org.jetbrains.annotations.NotNull; +import org.jetbrains.annotations.Nullable; + +/** + * Mapper implementation which maps fields of objects of type {@link T} to the columns by their names. Intended to use only with natively Review comment: > Intended to use only with natively supported types This is confusing. Which types are natively supported? How do I know if my POJO is supported or not? ########## File path: modules/api/src/main/java/org/apache/ignite/table/mapper/PojoMapper.java ########## @@ -0,0 +1,46 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.table.mapper; + +import org.jetbrains.annotations.NotNull; +import org.jetbrains.annotations.Nullable; + +/** + * Mapper implementation which maps fields of objects of type {@link T} to the columns by their names. Intended to use only with natively + * supported types. + * + * @param <T> Target type. + * @see OneColumnMapper + */ +public interface PojoMapper<T> extends Mapper<T> { + /** + * Return a field name for given column name when POJO individual fields are mapped to columns, otherwise fails. Review comment: ```suggestion * Returns a field name for a given column name when POJO individual fields are mapped to columns, otherwise fails. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
