SammyVimes commented on a change in pull request #495: URL: https://github.com/apache/ignite-3/pull/495#discussion_r767985736
########## File path: modules/network/src/test/java/org/apache/ignite/internal/network/serialization/ClassDescriptorParserTest.java ########## @@ -0,0 +1,355 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.network.serialization; + +import static org.junit.jupiter.api.Assertions.assertEquals; +import static org.junit.jupiter.api.Assertions.assertNotNull; +import static org.junit.jupiter.api.Assertions.assertThrows; + +import java.io.Externalizable; +import java.io.IOException; +import java.io.ObjectInput; +import java.io.ObjectInputStream; +import java.io.ObjectOutput; +import java.io.ObjectOutputStream; +import java.io.ObjectStreamException; +import java.io.Serializable; +import java.util.List; +import java.util.Map; +import java.util.function.Function; +import java.util.stream.Collectors; +import org.apache.ignite.internal.network.serialization.DefaultClassDescriptors.DefaultType; +import org.apache.ignite.lang.IgniteException; +import org.junit.jupiter.api.Test; + +/** + * Set of tests for the class descriptor parser. + */ +public class ClassDescriptorParserTest { + /** + * Descriptor parser context. + */ + private final ClassDescriptorParserContext context = new ClassDescriptorParserContext(); + + /** + * Descriptor parser. + */ + private final ClassDescriptorParser parser = new ClassDescriptorParser(context); + + static class SerializableClass implements Serializable { + private static final long serialVersionUID = 0L; + } + + @Test + public void testSerializable() { + ClassDescriptor descriptor = parser.parse(SerializableClass.class); + + assertEquals(SerializationType.SERIALIZABLE, descriptor.serializationType()); + assertEquals(0, descriptor.fields().size()); + } + + static class SerializableOverride implements Serializable { + private static final long serialVersionUID = 0L; + + private void writeObject(ObjectOutputStream out) throws IOException { + // No-op. + } + + private void readObject(ObjectInputStream in) + throws IOException, ClassNotFoundException { + // No-op. + } + + private void readObjectNoData() throws ObjectStreamException { + // No-op. + } + } + + @Test + public void testSerializableOverride() { + ClassDescriptor descriptor = parser.parse(SerializableOverride.class); + + assertEquals(SerializationType.SERIALIZABLE_OVERRIDE, descriptor.serializationType()); + assertEquals(0, descriptor.fields().size()); + } + + static class SerializableOverrideWriteReplace implements Serializable { + private static final long serialVersionUID = 0L; + + private void writeObject(ObjectOutputStream out) throws IOException { + // No-op. + } + + private void readObject(ObjectInputStream in) + throws IOException, ClassNotFoundException { + // No-op. + } + + private void readObjectNoData() throws ObjectStreamException { + // No-op. + } + + private Object writeReplace() throws ObjectStreamException { + // No-op. + return null; + } + } + + @Test + public void testSerializableOverrideWriteReplace() { + ClassDescriptor descriptor = parser.parse(SerializableOverrideWriteReplace.class); + + assertEquals(SerializationType.SERIALIZABLE_OVERRIDE_WRITE_REPLACE, + descriptor.serializationType()); + assertEquals(0, descriptor.fields().size()); + } + + static class SerializableOverrideReadResolve implements Serializable { + private static final long serialVersionUID = 0L; + + private void writeObject(ObjectOutputStream out) throws IOException { + // No-op. + } + + private void readObject(ObjectInputStream in) + throws IOException, ClassNotFoundException { + // No-op. + } + + private void readObjectNoData() throws ObjectStreamException { + // No-op. + } + + private Object readResolve() throws ObjectStreamException { + // No-op. + return null; + } + } + + @Test + public void testSerializableOverrideReadResolve() { + ClassDescriptor descriptor = parser.parse(SerializableOverrideReadResolve.class); + + assertEquals(SerializationType.SERIALIZABLE_OVERRIDE_READ_RESOLVE, + descriptor.serializationType()); + assertEquals(0, descriptor.fields().size()); + } + + static class SerializableOverrideWriteReplaceReadResolve implements Serializable { + private static final long serialVersionUID = 0L; + + private void writeObject(ObjectOutputStream out) throws IOException { + // No-op. + } + + private void readObject(ObjectInputStream in) + throws IOException, ClassNotFoundException { + // No-op. + } + + private void readObjectNoData() throws ObjectStreamException { + // No-op. + } + + private Object writeReplace() throws ObjectStreamException { + // No-op. + return null; + } + + private Object readResolve() throws ObjectStreamException { + // No-op. + return null; + } + } + + @Test + public void testSerializableOverrideWriteReplaceReadResolve() { + ClassDescriptor descriptor = parser.parse( + SerializableOverrideWriteReplaceReadResolve.class); + + assertEquals(SerializationType.SERIALIZABLE_OVERRIDE_WRITE_REPLACE_READ_RESOLVE, + descriptor.serializationType()); + assertEquals(0, descriptor.fields().size()); + } + + static class SerializableWriteReplace implements Serializable { + private static final long serialVersionUID = 0L; + + private Object writeReplace() throws ObjectStreamException { + // No-op. + return null; + } + } + + @Test + public void testSerializableWriteReplace() { + ClassDescriptor descriptor = parser.parse(SerializableWriteReplace.class); + + assertEquals(SerializationType.SERIALIZABLE_WRITE_REPLACE, descriptor.serializationType()); + assertEquals(0, descriptor.fields().size()); + } + + @SuppressWarnings("CheckStyle") + static class SerializableReadResolve implements Serializable { + private static final long serialVersionUID = 0L; + + private Object readResolve() throws ObjectStreamException { + // No-op. + return null; + } + } + + @Test + public void testSerializableReadResolve() { + ClassDescriptor descriptor = parser.parse(SerializableReadResolve.class); + + assertEquals(SerializationType.SERIALIZABLE_READ_RESOLVE, descriptor.serializationType()); + assertEquals(0, descriptor.fields().size()); + } + + static class SerializableWriteReplaceReadResolve implements Serializable { + private static final long serialVersionUID = 0L; + + private Object writeReplace() throws ObjectStreamException { + // No-op. + return null; + } + + private Object readResolve() throws ObjectStreamException { + // No-op. + return null; + } + } + + @Test + public void testSerializableWriteReplaceReadResolve() { + ClassDescriptor descriptor = parser.parse(SerializableWriteReplaceReadResolve.class); + + assertEquals(SerializationType.SERIALIZABLE_WRITE_REPLACE_READ_RESOLVE, + descriptor.serializationType()); + assertEquals(0, descriptor.fields().size()); + } + + @SuppressWarnings("RedundantThrows") + static class ExternalizableClass implements Externalizable { + public ExternalizableClass() { + } + + @Override + public void writeExternal(ObjectOutput out) throws IOException { + // No-op. + } + + @Override + public void readExternal(ObjectInput in) throws IOException, ClassNotFoundException { + // No-op. + } + } + + @Test + public void testExternalizable() { + ClassDescriptor descriptor = parser.parse(ExternalizableClass.class); + + assertEquals(SerializationType.EXTERNALIZABLE, descriptor.serializationType()); + assertEquals(0, descriptor.fields().size()); + } + + static class ArbitraryClass { + } + + @Test + public void testArbitrary() { + ClassDescriptor descriptor = parser.parse(ArbitraryClass.class); + + assertEquals(SerializationType.ARBITRARY, descriptor.serializationType()); + assertEquals(0, descriptor.fields().size()); + } + + @SuppressWarnings({"ExternalizableWithoutPublicNoArgConstructor", "RedundantThrows"}) + static class ExternalizableWithoutPublicNoArgConstructor implements Externalizable { + public ExternalizableWithoutPublicNoArgConstructor(@SuppressWarnings("unused") int unused) { + } + + @Override + public void writeExternal(ObjectOutput out) throws IOException { + // No-op. + } + + @Override + public void readExternal(ObjectInput in) throws IOException, ClassNotFoundException { + // No-op. + } + } + + @Test + public void testExternalizableWithoutConstructor() { + assertThrows(IgniteException.class, + () -> parser.parse(ExternalizableWithoutPublicNoArgConstructor.class)); + } + + /** Class that holds a set of all types parseable by the class descriptor parser. */ + @SuppressWarnings("unused") + static class Holder { + private SerializableClass field1; + + private ExternalizableClass field2; + + private ArbitraryClass field3; + + private int primitiveField; + } + + @Test + public void testHolderClass() { + ClassDescriptor holderDescriptor = parser.parse(Holder.class); + + ClassDescriptor serializableDescriptor = context.getDescriptor(SerializableClass.class); + assertNotNull(serializableDescriptor); + + ClassDescriptor externalizableDescriptor = context.getDescriptor(ExternalizableClass.class); + assertNotNull(externalizableDescriptor); + + ClassDescriptor arbitraryDescriptor = context.getDescriptor(ArbitraryClass.class); + assertNotNull(arbitraryDescriptor); + + ClassDescriptor intDescriptor = context.getDescriptor(DefaultType.INT.descriptorId()); + assertNotNull(intDescriptor); + + List<FieldDescriptor> fields = holderDescriptor.fields(); + assertEquals(4, fields.size()); + + Map<String, FieldDescriptor> fieldsMap = fields.stream() Review comment: Excerpt from the javadocs of the Class#getDeclaredFields: ``` The elements in the returned array are not sorted and are not in any particular order. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
