sanpwc commented on a change in pull request #502:
URL: https://github.com/apache/ignite-3/pull/502#discussion_r768376571



##########
File path: 
modules/api/src/main/java/org/apache/ignite/table/manager/IgniteTables.java
##########
@@ -58,41 +59,12 @@
      */
     CompletableFuture<Table> createTableAsync(String name, 
Consumer<TableChange> tableInitChange);

Review comment:
       Here and below. Let's actualize javadoc for all create/alter/drop 
methods in a following way:
   - For async - specify that the result future will be completed with 
TableAlreadyExistsException/TableNotFoundException.
   - For sync - add throws clause with corresponding exception.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to