vldpyatkov commented on a change in pull request #502:
URL: https://github.com/apache/ignite-3/pull/502#discussion_r768578968
##########
File path:
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/TableManager.java
##########
@@ -706,99 +707,76 @@ public Table createTable(String name,
Consumer<TableChange> tableInitChange) {
*
* @param name Table name.
* @param tableInitChange Table configuration.
- * @param exceptionWhenExist If the value is {@code true}, an exception
will be thrown when the table already exists, {@code
- * false} means the existing table will be returned.
* @return A table instance.
*/
- private CompletableFuture<Table> createTableAsync(
- String name,
- Consumer<TableChange> tableInitChange,
- boolean exceptionWhenExist
- ) {
+ private CompletableFuture<Table> createTableAsyncInternal(String name,
Consumer<TableChange> tableInitChange) {
Review comment:
I do not consider that all internal method should have duplicate public
API javadoc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
