sashapolo commented on a change in pull request #468:
URL: https://github.com/apache/ignite-3/pull/468#discussion_r768625816
##########
File path:
modules/storage-rocksdb/src/main/java/org/apache/ignite/internal/storage/rocksdb/RocksDbTableStorage.java
##########
@@ -87,53 +73,42 @@
/** Data region for the table. */
private final RocksDbDataRegion dataRegion;
- /** Comparators factory for indexes. */
- private final BiFunction<TableView, String, Comparator<ByteBuffer>>
indexComparatorFactory;
-
/** List of closeable resources to close on {@link #stop()}. Better than
having a field for each one of them. */
private final List<AutoCloseable> autoCloseables = new ArrayList<>();
- /** Rocks DB instance itself. */
+ /** Rocks DB instance. */
private RocksDB db;
/** CF handle for meta information. */
@SuppressWarnings("unused")
- private ColumnFamilyHandle metaCfHandle;
+ private ColumnFamily metaCf;
Review comment:
This field was introduced by @ibessonov and he states that it is
reserved for future purposes... Or do you mean that we should use it somehow?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
