xtern commented on a change in pull request #9629:
URL: https://github.com/apache/ignite/pull/9629#discussion_r770748143
##########
File path:
modules/core/src/main/java/org/apache/ignite/internal/client/thin/ClientServicesImpl.java
##########
@@ -174,6 +206,8 @@ private void writeServiceInvokeRequest(
writer.writeObject(args[i]);
}
}
+
+ writer.writeMap(withCallCtx ?
((ServiceCallContextImpl)callCtx).values() : null);
Review comment:
> What if the user implements and passes to method their own
`ServiceCallContext` implementation? We should check it and throw an error with
reasonable message, or introduce some kind of `attributeNames()` method in
public interface, to get all possible attributes for this context.
Added explicit user arguments check.
> Also, should not write anything (including `null`) if
`ProtocolBitmaskFeature.SERVICE_INVOKE_CALLCTX` is not supported.
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
