sk0x50 commented on a change in pull request #514:
URL: https://github.com/apache/ignite-3/pull/514#discussion_r771408603
##########
File path: modules/api/src/main/java/org/apache/ignite/table/KeyValueView.java
##########
@@ -76,38 +79,41 @@
* Gets a nullable value associated with the given key.
*
* @param key A key which associated the value is to be returned. The key
cannot be {@code null}.
+ * @param tx The transaction or {@code null} to auto commit.
* @return Future representing pending completion of the operation.
- * @see #getNullable(Object)
+ * @see #getNullable(Object, Transaction)
*/
- default @NotNull CompletableFuture<NullableValue<V>> getNullableAsync(K
key) {
+ default @NotNull CompletableFuture<NullableValue<V>> getNullableAsync(K
key, @Nullable Transaction tx) {
//TODO: to be implemented
https://issues.apache.org/jira/browse/IGNITE-16115
throw new UnsupportedOperationException("Not implemented yet.");
}
/**
* Gets a value associated with the given key if exists, returns {@code
defaultValue} otherwise.
*
- * <p>Note: method has same semantic as {@link #get(Object)} with regard
to {@code null} values.
+ * <p>Note: method has same semantic as {@link #get(Object, Transaction)}
with regard to {@code null} values.
*
* @param key A key which associated the value is to be returned. The key
cannot be {@code null}.
+ * @param tx The transaction or {@code null} to auto commit.
* @return Value or {@code defaultValue}, if does not exist.
* @throws IllegalStateException If value for the key exists, and it is
{@code null}.
*/
- default V getOrDefault(K key, V defaultValue) {
+ default V getOrDefault(K key, V defaultValue, @Nullable Transaction tx) {
//TODO: to be implemented
https://issues.apache.org/jira/browse/IGNITE-16115
throw new UnsupportedOperationException("Not implemented yet.");
}
/**
* Gets a nullable value associated with the given key.
*
- * <p>Note: method has same semantic as {@link #get(Object)} with regard
to {@code null} values.
+ * <p>Note: method has same semantic as {@link #get(Object, Transaction)}
with regard to {@code null} values.
*
* @param key A key which associated the value is to be returned. The key
cannot be {@code null}.
+ * @param tx The transaction or {@code null} to auto commit.
* @return Future representing pending completion of the operation.
- * @see #getOrDefault(Object, Object)
+ * @see #getOrDefaultAsync(Object, Object, Transaction)
Review comment:
`getOrDefault(Object, Object, Transaction)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
