rpuch commented on a change in pull request #516:
URL: https://github.com/apache/ignite-3/pull/516#discussion_r773171524
##########
File path:
modules/network/src/main/java/org/apache/ignite/internal/network/serialization/ClassDescriptorFactory.java
##########
@@ -122,10 +119,11 @@ private ClassDescriptor externalizable(int descriptorId,
Class<? extends Externa
checkHasPublicNoArgConstructor(clazz);
return new ClassDescriptor(
- clazz,
- descriptorId,
- Collections.emptyList(),
- SerializationType.EXTERNALIZABLE
+ clazz,
+ descriptorId,
+ Collections.emptyList(),
+ new Serialization(SerializationType.EXTERNALIZABLE,
+ hasOverrideSerialization(clazz),
hasWriteReplace(clazz), hasReadResolve(clazz))
Review comment:
Fixed
##########
File path:
modules/network/src/main/java/org/apache/ignite/internal/network/serialization/ClassDescriptorFactory.java
##########
@@ -161,30 +159,25 @@ private static void
checkHasPublicNoArgConstructor(Class<? extends Externalizabl
* @return Class descriptor.
*/
private ClassDescriptor serializable(int descriptorId, Class<? extends
Serializable> clazz) {
- Method writeObject = getWriteObject(clazz);
- Method readObject = getReadObject(clazz);
- Method readObjectNoData = getReadObjectNoData(clazz);
-
- boolean overrideSerialization = writeObject != null && readObject !=
null && readObjectNoData != null;
-
- Method writeReplace = getWriteReplace(clazz);
- Method readResolve = getReadResolve(clazz);
-
- int serializationType = SerializationType.SERIALIZABLE;
+ return new ClassDescriptor(clazz, descriptorId, fields(clazz),
+ new Serialization(SerializationType.SERIALIZABLE,
+ hasOverrideSerialization(clazz),
hasWriteReplace(clazz), hasReadResolve(clazz)));
Review comment:
Fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
