alex-plekhanov commented on a change in pull request #9681:
URL: https://github.com/apache/ignite/pull/9681#discussion_r775490682
##########
File path:
modules/calcite/src/test/java/org/apache/ignite/internal/processors/query/calcite/integration/SortAggregateIntegrationTest.java
##########
@@ -27,41 +27,39 @@
import org.apache.ignite.cache.QueryIndex;
import org.apache.ignite.cache.QueryIndexType;
import org.apache.ignite.cache.affinity.rendezvous.RendezvousAffinityFunction;
-import org.apache.ignite.cache.query.FieldsQueryCursor;
import org.apache.ignite.configuration.CacheConfiguration;
import org.apache.ignite.configuration.IgniteConfiguration;
-import org.apache.ignite.internal.processors.query.QueryEngine;
-import org.apache.ignite.internal.processors.query.calcite.util.Commons;
-import org.apache.ignite.internal.util.typedef.X;
-import org.apache.ignite.testframework.junits.common.GridCommonAbstractTest;
import org.junit.Test;
-import static java.util.Collections.singletonList;
-
/**
* Sort aggregate integration test.
*/
-public class SortAggregateIntegrationTest extends GridCommonAbstractTest {
+public class SortAggregateIntegrationTest extends AbstractBasicIntegrationTest
{
/** */
public static final int ROWS = 103;
+ /** */
+ @Override protected int nodeCount() {
+ return 2;
+ }
+
/** {@inheritDoc} */
@Override protected void beforeTestsStarted() throws Exception {
Review comment:
Method is redundant
##########
File path:
modules/calcite/src/test/java/org/apache/ignite/internal/processors/query/calcite/integration/SortAggregateIntegrationTest.java
##########
@@ -184,18 +154,9 @@ private void fillCacheTest(IgniteCache c, int rows) throws
InterruptedException
/** */
int col1;
- /** */
- int col2;
-
- /** */
- int col3;
-
- /** */
- int col4;
-
/** */
TestValTbl1(int k) {
- col0 = col1 = col2 = col3 = col4 = k;
+ col0 = col1 = k;
Review comment:
`col1` is redundant too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
