AMashenkov commented on a change in pull request #518:
URL: https://github.com/apache/ignite-3/pull/518#discussion_r775494237



##########
File path: 
modules/storage-api/src/main/java/org/apache/ignite/internal/storage/index/IndexRow.java
##########
@@ -17,26 +17,22 @@
 
 package org.apache.ignite.internal.storage.index;
 
-import org.apache.ignite.internal.storage.PartitionStorage;
-import org.apache.ignite.internal.storage.SearchRow;
-
 /**
  * Represents an Index Row - a set of indexed columns and Primary Key columns 
(for key uniqueness).
  */
-public interface IndexRow {
+public interface IndexRow extends IndexBinaryRow {
     /**
-     * Returns the serialized presentation of this row as a byte array.
+     * Returns value of the indexed columns specified by index column order.
      *
-     * @return Serialized byte array value.
+     * @param idxColOrder Index column order.
+     * @return Value of the indexed columns.
      */
-    byte[] rowBytes();
+    Object value(int idxColOrder);
 
     /**
-     * Returns the Primary Key that is a part of this row.
-     *
-     * <p>This is a convenience method for easier extraction of the Primary 
Key to use it for accessing the {@link PartitionStorage}.
+     * Returns count of columns at the index row.
      *
-     * @return Primary key of the associated {@link PartitionStorage}.
+     * @return Count of columns at the index row.
      */
-    SearchRow primaryKey();
+    int columnsCount();

Review comment:
       Why does a row has columnCount, but not the index descriptor?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to