korlov42 commented on a change in pull request #520:
URL: https://github.com/apache/ignite-3/pull/520#discussion_r776294504
##########
File path:
modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/externalize/RelJsonReader.java
##########
@@ -142,8 +144,17 @@ public RelTraitSet getTraitSet() {
/** {@inheritDoc} */
@Override
public RelOptTable getTable(String table) {
- List<String> list = getStringList(table);
- return relOptSchema.getTableForMember(list);
+ throw new AssertionError();
Review comment:
> can u append additional messge into AssertionError ?
Yes, of course. What exactly would you like to see in the message?
> do we really need getTableById ? why can`t refactor getTable ?
Someone could accidentally use it, so I would prefer to get a clear error,
rather that UB (what if `IgniteUuid#fromString` starts to ignore leading and
trailing braces or starts to return NULL in case it unable to parse the given
input string?)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
