rpuch commented on a change in pull request #530: URL: https://github.com/apache/ignite-3/pull/530#discussion_r781088121
########## File path: modules/network/src/main/java/org/apache/ignite/internal/network/serialization/marshal/Cycles.java ########## @@ -0,0 +1,41 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.network.serialization.marshal; + +import org.apache.ignite.internal.network.serialization.ClassDescriptor; + +/** + * Logic related to cycles in object graphs. + */ +class Cycles { Review comment: Well, the main class (the marshaller) is already bloated. I am trying to explore any possibility to cut it to pieces. :) Hence the class. Also, it has a distinctive responsibility, different from the marshaller responsibility: it's just about tracking cycleables. In the future, we might widen the notion of non-cycleable classes, so `Cycles` would contain more logic (and more code). One more object on the heap is not a problem at all as it's one per marshaller which will not be created in huge numbers. I generally dislike any statics as they tend to spread through the system, and when you have a lot of them, you have a problem. But for now it makes sense to leave it as a static... I'll do it shortly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
